Overhaul global filtering of participants #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvandyken
force-pushed
the
fix/participant-label-filtering
branch
from
b7e52cb to
95240f9
Compare
kaitj
reviewed
Dec 12, 2023
kaitj
approved these changes
Dec 13, 2023
|
Just want a second review on this one. @Bradley-Karat, @myousif9, are one of you able to take a look? |
|
Everything looks good to me! |
Bradley-Karat
approved these changes
Dec 14, 2023
pvandyken
force-pushed
the
fix/participant-label-filtering
branch
4 times, most recently
from
ee116bb to
2559b09
Compare
--participant-filter and --exclude-participant filter have had a couple of bugs over the past few versions: 1. Both terms would apply to every single component, even components without the subject entity. These components would have all of their entries filtered out 2. Using --exclude-participant-filter would turn on regex matching mode for every single filter. This changed the meaning of the filters (e.g. allowing partial matches), leading to workflow disruption The overhaul fixes both bugs, while improving the organization of the input generation code. Additionally, the documentation states the magic filter `regex_search: True` can be used to enable regex searching for a block of filters. This hasn't worked for the past few versions. Rather than fix it, the behaviour has been silently disabled in preparation for an overhaul of the regex filtering api. Mention of this feature has been removed from documentation Resolves khanlab#303 Resolves khanlab#216
pvandyken
force-pushed
the
fix/participant-label-filtering
branch
from
2559b09 to
0adbef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--participant-filter and --exclude-participant filter have had a couple of bugs over the past few versions:
The overhaul fixes both bugs, while improving the organization of the
input generation code.
Additionally, the documentation states the magic filter
regex_search: Truecan be used to enable regex searching for a block of filters. This hasn't worked for the past few versions. Rather than fix it, the behaviour has been silently disabled in preparation for an overhaul of the regex filtering apiResolves #303
Resolves #216