Refactor install steps into resusable workflow #341
Conversation
pvandyken
force-pushed
the
maint/gh-actions/refactor
branch
from
f5e3943 to
5fd4207
Compare
There was a problem hiding this comment.
This largely looks good to me with one question. On pushing new changes to an open PR, does it reference github.event.pull_request.id or github.event.after? If the latter, would this mean the setup is rerun everytime there is a new push? (Assuming this references the commit hash.)
And yes, I will end up throwing it in the centralized repo! I've added a modified version of it in the centralized repo, pending a test before merging into main. Had to change it slightly as (I think) it had to be defined as a job rather than a composite action. In any case, I'll ping you over there once I make the PR.
|
The install action is now available on the tagged |
pvandyken
force-pushed
the
maint/gh-actions/refactor
branch
from
b54ff34 to
ec3e0a9
Compare
.github/workflows/test.yml
Outdated
| id: setup-python | ||
| uses: actions/setup-python@v4 | ||
| - name: Install | ||
| uses: khanlab/actions/.github/actions/action-setup_task-installPyProject |
There was a problem hiding this comment.
I can't recall at the moment - wondering if you know what the behaviour is if you don't tag a specific version? I assume it would either use the latest tag or whatever is on main?
There was a problem hiding this comment.
Good call, I'll add a tag
pvandyken
added
maintenance
pvandyken
force-pushed
the
maint/gh-actions/refactor
branch
from
53d732e to
4a3d59c
Compare
Regex was not matching the entire container path, leading to incorrect error messages
Project installation uses khanlab/actions Docker container setup is refactored into a composite rule
pvandyken
force-pushed
the
maint/gh-actions/refactor
branch
from
4a3d59c to
a36eca3
Compare
Completing the Actions refactoring suggested by @tkkuehn.
@kaitj, you're welcome to take the flow and incorporate it into your centralized repository, if you wish