-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency upper-caps and update #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely lgtm code-wise (just realized the one test is failing for py3.11), with a very minor comment (that upon second thought doesn't really require any action given these are more dev dependencies than for distribution).
Aside from cookiecutter
(which will get replaced in #336 anyway), is there opposition to changing the ^
to a >=
?. The caret requirements would be placing an upper-cap on the dependencies if I am interpreting the poetry docs correctly. Making the change would also bring us closer to following PEP440.
For a specific dependency, or for everything? And are you asking about removing the |
The test failure should be fixed by a commit I made in #336, so I'll wait for that one to merge, then deal with the failure here |
More a general thing and yeah, replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending tests passing this looks good
bef3139
to
3cffa9c
Compare
I'm going to keep the |
Remove cached-property dep since functionality is provided by functools in py38 Remove all upper version limits in main dependency block. Where kept, justification comment is added Upgraded pvandyken-deprecated dependency, which packages proper typing support (thus, remove our own typings file)
3cffa9c
to
4360ec4
Compare
A recent hypothesis release by default loads a directory based database of examples. This is incompatible with pyfakefs as hypothesis is unable to access the file system. Until a full workaround can be designed, we'll need to use the inmemory database
Remove cached-property dep since functionality is provided by functools in py38
Remove all upper version limits in main dependency block. Where kept, justification comment is added
Upgraded pvandyken-deprecated dependency, which packages proper typing support (thus, remove our own typings file)