Overhaul snakebids create

snakebids/admin.py

@@ -84,7 +84,7 @@ def gen_parser() -> argparse.ArgumentParser:
 
 
 def main() -> None:
-    """Invoke snakebids cli."""
+    """Invoke Snakebids cli."""
 
     parser = gen_parser()
     args = parser.parse_args()

snakebids/project_template/copier.yaml

@@ -41,8 +41,7 @@ app_version:
 
 build_system:
   help: >
-    What build system would you like to use? If you don't know what this means,
-    choose setuptools
+    What build system would you like to use? If unsure, choose setuptools
   choices:
     - setuptools
     - poetry

snakebids/project_template/{% if build_system != 'poetry' %}pyproject.toml{% endif %}.jinja

@@ -30,6 +30,10 @@ requires-python = ">=3.8,<3.12"
 dependencies = [
     "snakemake >= {{ snakemake_version }}",
     "snakebids >= {{ snakebids_version }}",
+    {# Explicitely specify numpy version for py38 until snakebids 0.10.x to
+       work around specification bug causing numpys too high for py38 to be
+       locked by pdm -#}
+    "numpy <=1.24.4; python_version < \"3.9\"",
 ]
 
 [project.scripts]

snakebids/tests/test_admin.py

@@ -37,6 +37,7 @@ def test_fails_if_invalid_subcommand(
         name=st.text()
         .filter(lambda s: not re.match(r"^[a-zA-Z_][a-zA-Z_0-9]*$", s))
         .filter(lambda s: is_valid_filename(s, Platform.LINUX))
+        .filter(lambda s: s not in {".", ".."})
     )
     @allow_function_scoped
     def test_create_fails_with_invalid_filename(
@@ -55,7 +56,11 @@ def test_create_fails_with_invalid_filename(
         assert "valid python module" in capture.err
         assert name in capture.err
 
-    @given(name=st.text().filter(lambda s: is_valid_filename(s, Platform.LINUX)))
+    @given(
+        name=st.text()
+        .filter(lambda s: is_valid_filename(s, Platform.LINUX))
+        .filter(lambda s: s not in {".", ".."})
+    )
     @allow_function_scoped
     def test_create_fails_missing_parent_dir(
         self,

snakebids/tests/test_generate_inputs.py

@@ -556,7 +556,7 @@ def get_subset(of: Iterable[T]) -> list[T]:
 
 class TestCustomPaths:
     @pytest.fixture()
-    def temp_dir(self, fakefs_tmpdir: Path):
+    def temp_dir(self, fakefs_tmpdir: Path, bids_fs: Path):
         return fakefs_tmpdir
 
     def generate_test_directory(

snakebids/tests/test_template.py

@@ -235,11 +235,17 @@ def test_template_dry_runs_successfully(tmp_path: Path, build: BuildSystems, ven
             "-v",
             f"{tmp_path / app_name}:/app",
             "--rm",
-            "snakebids/test-template:dev",
+            f"snakebids/test-template:{platform.python_version()}",
             venv,
             app_name,
         ],
         capture_output=True,
-        check=True,
+        check=False,
     )
+    try:
+        cmd.check_returncode()
+    except Exception as err:
+        print(cmd.stdout)
+        print(cmd.stderr, file=sys.stderr)
+        raise err
     assert "All set" in cmd.stdout.decode()