Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set SnakeBidsApp.args in run_snakemake #310

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

tkkuehn
Copy link
Contributor

@tkkuehn tkkuehn commented Jun 15, 2023

Proposed changes

Resolves #264 (I think). This is a pretty simple change, but helpful if you want to write a plugin that reacts to CLI args that don't cause other downstream changes to the SnakeBidsApp's attributes.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@tkkuehn tkkuehn merged commit 70e9fb7 into khanlab:main Jun 21, 2023
@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose args on SnakeBidsApp for plugins
3 participants