Update cookiecutter template #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitj
added
the
maintenance
kaitj
force-pushed
the
maint/cookiecutter
branch
2 times, most recently
from
005841c to
0a4bb99
Compare
- change .rst files to .md - update cookiecutter variables - app_name changed to private rendered variable - constants like version numbers set to private unrendered variables - change setup.py to pyproject.toml - updated pipeline_description.json to be more human readible
kaitj
force-pushed
the
maint/cookiecutter
branch
from
0a4bb99 to
aa800a0
Compare
Already removed from cookiecutter. May need a separate way to specify where the project ends up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Was playing around a bit more with cookiecutter and decided to do a little bit of maintenance for the snakebids cookiecutter, though I may have missed a few things. Some changes include:
{{ cookiecutter.app_name }}so that the user isn't asked for bothapp_full_nameandapp_name).setup.pytopyproject.tomlI had to ignore the
project_templatefolder from the linting, which I don't really want to do. The jinja syntax in thepyproject.tomlthere is conflicting with the ruff linter and I couldn't get it to work excluding the singlepyproject.tomlfile. If anyone has any ideas, I'd be open to it.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.