Update deprecation dependency to own package #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvandyken
force-pushed
the
maint-update-deprecation-dep
branch
from
45374fb to
3fc3019
Compare
tkkuehn
approved these changes
Apr 6, 2023
pvandyken
added
the
maintenance
Move away from the previous git dependency, which was more unstable
pvandyken
force-pushed
the
maint-update-deprecation-dep
branch
from
3fc3019 to
f418fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I did the deprecations in #251, I used a custom fork of deprecation. This had the poetry entry pointing to a custom commit on a git repository, which seemed rather unstable to me (the versioning probably wouldn't work correctly, and you'd end up with conflict if another library used the same deprecation package). So I've separated the fork (and "modernized" the code to my own liking) in my own namespaced package pvandyken-deprecated.