Skip to content

Commit

Permalink
Restrict pulp version in template app
Browse files Browse the repository at this point in the history
The latest versions of pulp dropped a deprecated api snakemake
dependended on. Newer versions of snakemake will address this, but older
versions don't have an upper pin on pulp.

We cannot lower-pin the snakemake version, as we need older snakemakes
to maintain support for python < 3.11.
  • Loading branch information
pvandyken committed Jan 15, 2024
1 parent b38d6b2 commit c3bba2f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ requires-python = "{{ python_version }}"
dependencies = [
"snakemake >= {{ snakemake_version }},<8",
"snakebids >= {{ snakebids_version }}",
{#- newer pulps are incompatible with old snakemakes, and we need to support
old snakemakes for python versions <3.11. So cap pulp to the last working
version
#}
"pulp < 2.8.0",
]

[project.scripts]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ classifiers = [
python = "{{ python_version }}"
snakemake = ">={{ snakemake_version }},<8"
snakebids = ">={{ snakebids_version }}"
{#- newer pulps are incompatible with old snakemakes, and we need to support
old snakemakes for python versions <3.11. So cap pulp to the last working
version
#}
pulp = "<2.8.0"
pandas = [
{ version = "<=2.0.3", python = "<3.9" },
{ version = ">=2.1.1", python = ">=3.12" },
Expand Down

0 comments on commit c3bba2f

Please sign in to comment.