Impose upper limit to pyright

pyproject.toml

@@ -80,7 +80,6 @@ pytest = "^7.0.0"
 pytest-mock = "^3.7.0"
 poethepoet = "^0.25.1"
 pre-commit = "^3.0.0"
-# need custom fork of mkinit to handle .pyi files. PR to main repo pending
 # a mkinit dep has the 'platform_system == "Windows"' as a marker on an incompatible dependeny
 #   (pydantic<2.0 cf copier), so set the inverse as a marker here so mkinit can
 #   still be resolved
@@ -90,7 +89,9 @@ pytest-benchmark = "^4.0.0"
 pyfakefs = "^5.1.0"
 pyparsing = "^3.0.9"
 pathvalidate = "^3.0.0"
-pyright = "^1.1.339"
+# Bug in .358 preventing the types from the converter arguments of attrs classes to
+# propogate properly
+pyright = "^1.1.339,<1.1.358"
 ruff = "^0.1.7"
 pytest-xdist = "^3.3.1"
 pytest-split = "^0.8.1"

snakebids/io/yaml.py

@@ -14,7 +14,7 @@ def path2str(dumper: Dumper, data: Path):
         return dumper.represent_scalar(
             "tag:yaml.org,2002:str",
             str(data),
-        )  # type: ignore
+        )
 
     def to_dict(dumper: Dumper, data: OrderedDict[Any, Any]):
         return dumper.represent_dict(dict(data))

snakebids/utils/containers.py

@@ -62,8 +62,8 @@ def __repr__(self) -> str:
         return f"{self.__class__.__name__}({list(self._data)})"
 
     @override
-    def __contains__(self, item: object, /) -> bool:
-        return item in self._data
+    def __contains__(self, value: object) -> bool:
+        return value in self._data
 
     @override
     def __hash__(self):