Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of labels for dynamic parcellation #23

Open
kaitj opened this issue Dec 8, 2022 · 3 comments
Open

Consistency of labels for dynamic parcellation #23

kaitj opened this issue Dec 8, 2022 · 3 comments

Comments

@kaitj
Copy link
Collaborator

kaitj commented Dec 8, 2022

The problem

Something that came up, but one thought was whether the indices of the merged labels would be consistent if the parcellations are dynamically created (e.g. thalamus segmentation per subject). The issue arises if different subjects have a different number of parcellations for whatever reason, leading to inconsistent labeling across subjects.

Currently, the the labels are merged in an incremental order based on what is present in the base and overlay images (correct me if I'm wrong here @tkkuehn. Need to give this some more thought, but one way could possibly to leverage the metadata to determine label indices (e.g. new overlay index = old overlay index + max(base overlay index)).

Environment

N/A

@kaitj
Copy link
Collaborator Author

kaitj commented Feb 1, 2023

I think this is now resolved by #36? @tkkuehn

@tkkuehn
Copy link
Collaborator

tkkuehn commented Feb 1, 2023

Right now (i.e. since #36 was merged), as long as the metadata is consistent across all subjects, the output labels will also be consistent. Notably if the metadata is different across subjects, this is still an issue.

@kaitj
Copy link
Collaborator Author

kaitj commented Feb 1, 2023

Ahh that is fair - that was not one I had considered when writing this issue. I can't think of any situation where the metadata would be different across subjects (at the moment) within a study.

We can put this on the agenda for next week to talk about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants