Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label 1 being ignored #24

Closed
kaitj opened this issue Dec 8, 2022 · 1 comment · Fixed by #25
Closed

Label 1 being ignored #24

kaitj opened this issue Dec 8, 2022 · 1 comment · Fixed by #25
Labels
bug Something isn't working

Comments

@kaitj
Copy link
Collaborator

kaitj commented Dec 8, 2022

The problem

Noticed this while labelmerge through dbsc. Label index 1 seems to be getting ignored when assembling the two labels together. The metadata appears to have all the correct information however.

image

Can see in the screenshot, the orange is from the base image that is under the combined image in grayscale. In this particular example, the parcellation (left SN) for label 1 is missing from the combined image, and instead label 1 gets assigned to the wrong parcel (right SN). Presumably, this error propagates to the other labels too.

May be related to #23, which is how I first started digging into this.

Environment

  • Operating System: Debian "bullseye" (docker container)
  • Label merge version: v0.1.0-pre.1
@kaitj kaitj added the bug Something isn't working label Dec 8, 2022
@kaitj
Copy link
Collaborator Author

kaitj commented Dec 9, 2022

This is now fixed from #25

@kaitj kaitj linked a pull request Dec 9, 2022 that will close this issue
@kaitj kaitj closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant