Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ali fixes to dev branch #326

Closed
wants to merge 0 commits into from
Closed

Ali fixes to dev branch #326

wants to merge 0 commits into from

Conversation

jordandekraker
Copy link
Collaborator

No description provided.

@jordandekraker
Copy link
Collaborator Author

@akhanf I think I got your updates to master resolved here correctly, but can you please confirm?

@akhanf
Copy link
Member

akhanf commented Dec 12, 2024

The config file changes aren't needed (the bids args are now added automatically), but otherwise looks fine I think.

@akhanf
Copy link
Member

akhanf commented Dec 13, 2024

@jordandekraker looks like you (accidentally?) merged dev-2.0.0 into master..
we should undo that as we wanted to reserve this until 2.0 release candidate is ready, so we don't break things on master along the way.. I can do a force-push to undo the changes, but then would want to make sure you don't use any branches since that merge (~5pm sunday)

@jordandekraker
Copy link
Collaborator Author

I think this way is correct. The scope of this PR is to merge commits from master into 2.0.0, but there were merge conflicts so i needed that last commit to resolve them. Since the 2.0.0 changes are newer than master, github automatically names this merge as 2.0.0 into master but actually its still within the scope of 2.0.0 (no changes to master).

The funny thing is, i can't take out the config changes from that merge commit since there's not an actual branch for master that's within this 2.0.0 😆 i'll roll back the merge and try again

@jordandekraker
Copy link
Collaborator Author

I was wrong, my merge got pushed to master 😞
We'll clean it up as discussed via zoom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants