Skip to content

Commit

Permalink
bugfix for using L or R template injection
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan DeKraker committed Jul 10, 2024
1 parent e6967c8 commit 98ea109
Show file tree
Hide file tree
Showing 2 changed files with 64 additions and 23 deletions.
10 changes: 7 additions & 3 deletions hippunfold/config/snakebids.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -384,21 +384,25 @@ template_based_segmentation:
hemi:
- R
- L
CIVM:
dHCP:
hemi:
- R
- L

MBMv2:
hemi:
- R
MBMv3:
hemi:
- R
ABAv3:
CIVM:
hemi:
- R
- L
dHCP:
upenn:
hemi:
- R
ABAv3:
hemi:
- R
- L
Expand Down
77 changes: 57 additions & 20 deletions hippunfold/workflow/rules/shape_inject.smk
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,36 @@
# Template-based segmentation supports templates that have only a single hemisphere
# by mapping it to the flipped version of the other hemisphere.
# If a template has both L and R files, then we set hemi_constrained_wildcard to L|R.
# If a hemisphere is missing data, then we set it to flip that, e.g. if L missing, then use Lflip|R

hemi_constraints = []
if config["template"] in config["template_based_segmentation"]:
for hemi in config["hemi"]:
if hemi in config["template_based_segmentation"][config["template"]]["hemi"]:
hemi_constraints.append(hemi)
else:
hemi_constraints.append(f"{hemi}flip")

hemi_constrained_wildcard = "{{hemi,{constraints}}}".format(
constraints="|".join(hemi_constraints)
)


def flipped(wildcards):
"""function to map hemi in wildcards from Lflip to R, or Rflip to L,
for use in rules where e.g. the output wildcard is Lflip, but for the input, R is desired, such as
when mapping a R hemi dseg to the Lflip hemisphere of a subject."""

if wildcards.hemi == "L" or wildcards.hemi == "R":
return wildcards
elif wildcards.hemi == "Lflip":
wildcards.hemi = "R"
return wildcards
elif wildcards.hemi == "Rflip":
wildcards.hemi = "L"
return wildcard


def get_input_for_shape_inject(wildcards):
if config["modality"] == "cropseg":
seg = bids(
Expand All @@ -6,7 +39,7 @@ def get_input_for_shape_inject(wildcards):
**config["subj_wildcards"],
suffix="dseg.nii.gz",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
).format(**wildcards)
elif get_modality_key(config["modality"]) == "seg":
modality_suffix = get_modality_suffix(config["modality"])
Expand All @@ -29,7 +62,7 @@ def get_input_for_shape_inject(wildcards):
suffix="dseg.nii.gz",
desc="nnunet",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
).format(**wildcards)
return seg

Expand All @@ -42,7 +75,7 @@ def get_input_splitseg_for_shape_inject(wildcards):
**config["subj_wildcards"],
suffix="dsegsplit",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
).format(**wildcards)

elif get_modality_key(config["modality"]) == "seg":
Expand All @@ -64,11 +97,12 @@ def get_input_splitseg_for_shape_inject(wildcards):
suffix="dsegsplit",
desc="nnunet",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
).format(**wildcards)
return seg



rule prep_segs_for_greedy:
input:
"{prefix}_dseg.nii.gz",
Expand All @@ -92,7 +126,7 @@ rule import_template_shape:
params:
template_seg=lambda wildcards, input: Path(input.template_dir)
/ config["template_files"][config["inject_template"]]["dseg"].format(
**wildcards
**flipped(wildcards)
),
output:
template_seg=bids(
Expand All @@ -101,6 +135,7 @@ rule import_template_shape:
space="template",
**config["subj_wildcards"],
desc="hipptissue",
hemi=hemi_constrained_wildcard,
suffix="dseg.nii.gz"
),
group:
Expand Down Expand Up @@ -164,6 +199,7 @@ rule template_shape_reg:
space="template",
**config["subj_wildcards"],
desc="hipptissue",
hemi="{hemi}",
suffix="dsegsplit"
),
subject_seg=get_input_splitseg_for_shape_inject,
Expand All @@ -183,7 +219,7 @@ rule template_shape_reg:
to="subject",
space="corobl",
type_="ras",
hemi="{hemi,Lflip|R}"
hemi=hemi_constrained_wildcard,
),
warp=bids(
root=work,
Expand All @@ -194,7 +230,7 @@ rule template_shape_reg:
from_="template",
to="subject",
space="corobl",
hemi="{hemi,Lflip|R}"
hemi=hemi_constrained_wildcard,
),
group:
"subj"
Expand All @@ -205,7 +241,7 @@ rule template_shape_reg:
bids(
root="logs",
**config["subj_wildcards"],
hemi="{hemi,Lflip|R}",
hemi=hemi_constrained_wildcard,
suffix="templateshapereg.txt"
),
shell:
Expand All @@ -222,6 +258,7 @@ rule template_shape_inject:
space="template",
**config["subj_wildcards"],
desc="hipptissue",
hemi="{hemi}",
suffix="dseg.nii.gz"
),
subject_seg=get_input_for_shape_inject,
Expand All @@ -235,7 +272,7 @@ rule template_shape_inject:
to="subject",
space="corobl",
type_="ras",
hemi="{hemi}"
hemi="{hemi}",
),
warp=bids(
root=work,
Expand All @@ -246,7 +283,7 @@ rule template_shape_inject:
from_="template",
to="subject",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
),
params:
interp_opt="-ri LABEL 0.2vox",
Expand All @@ -258,14 +295,14 @@ rule template_shape_inject:
suffix="dseg.nii.gz",
desc="inject",
space="corobl",
hemi="{hemi,Lflip|R}"
hemi=hemi_constrained_wildcard,
),
log:
bids(
root="logs",
**config["subj_wildcards"],
suffix="templateshapeinject.txt",
hemi="{hemi,Lflip|R}"
hemi=hemi_constrained_wildcard,
),
group:
"subj"
Expand All @@ -289,7 +326,7 @@ rule inject_init_laplace_coords:
to="subject",
space="corobl",
type_="ras",
hemi="{hemi}"
hemi="{hemi}",
),
warp=bids(
root=work,
Expand All @@ -300,7 +337,7 @@ rule inject_init_laplace_coords:
from_="template",
to="subject",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
),
template_dir=Path(download_dir) / "template" / config["inject_template"],
params:
Expand All @@ -319,7 +356,7 @@ rule inject_init_laplace_coords:
suffix="coords.nii.gz",
desc="init",
space="corobl",
hemi="{hemi,R|Lflip}"
hemi=hemi_constrained_wildcard,
),
log:
bids(
Expand All @@ -329,7 +366,7 @@ rule inject_init_laplace_coords:
label="{autotop}",
suffix="injectcoords.txt",
desc="init",
hemi="{hemi,R|Lflip}"
hemi=hemi_constrained_wildcard,
),
group:
"subj"
Expand Down Expand Up @@ -365,7 +402,7 @@ rule unflip_init_coords:
suffix="coords.nii.gz",
desc="init",
space="corobl",
hemi="{hemi,L}"
hemi="{hemi,L|R}"
),
container:
config["singularity"]["autotop"]
Expand All @@ -385,7 +422,7 @@ rule reinsert_subject_labels:
suffix="dseg.nii.gz",
desc="inject",
space="corobl",
hemi="{hemi}"
hemi="{hemi}",
),
subject_seg=get_input_for_shape_inject,
params:
Expand All @@ -400,7 +437,7 @@ rule reinsert_subject_labels:
suffix="dseg.nii.gz",
desc="postproc",
space="corobl",
hemi="{hemi,Lflip|R}"
hemi=hemi_constrained_wildcard,
),
group:
"subj"
Expand Down Expand Up @@ -429,7 +466,7 @@ rule unflip_postproc:
suffix="dseg.nii.gz",
desc="postproc",
space="corobl",
hemi="{hemi,L}",
hemi="{hemi,L|R}",
**config["subj_wildcards"]
),
container:
Expand Down

0 comments on commit 98ea109

Please sign in to comment.