Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB_WDI source improvement #208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WB_WDI source improvement #208

wants to merge 2 commits into from

Conversation

nicolas-graves
Copy link

@nicolas-graves nicolas-graves commented Nov 5, 2024

Add WDI dataflow/codelist/datastructure.

However, it uses a lot of unconventional quirks, which I would be happy to correct.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@nicolas-graves
Copy link
Author

The tests are failing, but I'm not sure it has something to do with the PR itself.

@nicolas-graves
Copy link
Author

This is actually not working that great because it relies on the assumption that dataflow is called without arguments, which is not true in the general case.

@khaeru
Copy link
Owner

khaeru commented Nov 12, 2024

I still will need to find time to look more closely at what this is doing.

In the meanwhile, one question for context: is this the same as or similar to this workaround that I have downstream?

In essence, there I found that the WB_WDI source does not really implement the SDMX-REST API per the standard. I responded by directly accessing a URL from their documentation. Is this PR similar in trying to handle a certain documented/known non-standard API behaviour? If so it will be important to have (or reference) a clear statement of what that behaviour is.

@nicolas-graves
Copy link
Author

@khaeru It seems indeed to be the same thing for codelists as the link you pointed at. I think the dataflow implementation on my side is most probably erroneous and should be discarded (since there are dataflow calls in higher level commands). I'll check to verify that codelists and datastructures are not used in other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants