Downgrade jdk8 to 1.8.0_262-b19 to avoid timestamp issue #16
Conversation
|
@kgyrtkirk @zabetak Pls take a look, the lateset zulu8-jdk would cause timestamp issue in CI, so we downgrade it to the original jdk8 version. FYI: apache/hive#5004 (comment) |
|
Is there a HIVE jira for the problem? If not please create one. Can you also please clarify if the problem is in JDK or in our code? |
|
Hive jira: HIVE-28014 |
|
@wecharyu According to https://issues.apache.org/jira/browse/HIVE-28014?focusedCommentId=17808601&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17808601. It seems that you pushed this change to production. Please clarify if that's the case so that we merge this PR as well. |
Yes, I have applied this patch on production as a hot fix. Pls help review it. |
There was a problem hiding this comment.
The change looks somewhat hacky since we first install the latest JDK8 and then patch the installation directories with an earlier version. Nevertheless, the fix its already deployed in prod and building the image passes so I am inclined to merge it as is. If we want to improve we can do it as a follow-up.
I will merge this shortly.
| curl -s https://repos.azul.com/azul-repo.key | sudo gpg --dearmor -o /usr/share/keyrings/azul.gpg | ||
| echo "deb [signed-by=/usr/share/keyrings/azul.gpg] https://repos.azul.com/zulu/deb stable main" | sudo tee /etc/apt/sources.list.d/zulu.list | ||
|
|
||
| apt-get update | ||
| apt-get install -y zulu8-jdk zulu11-jdk zulu17-jdk | ||
|
|
||
| # downgrade jdk8 to 1.8.0_262-b19 to avoid timestamp issue | ||
| wget -nv https://cdn.azul.com/zulu/bin/zulu8.48.0.51-ca-fx-jdk8.0.262-linux_x64.tar.gz | ||
| tar zxf zulu8.48.0.51-ca-fx-jdk8.0.262-linux_x64.tar.gz && rm zulu8.48.0.51-ca-fx-jdk8.0.262-linux_x64.tar.gz |
There was a problem hiding this comment.
I dont think this should be the way; dont know much about the reasons, especially not like installinv a package the wget+tar
have you tried to use apt better?
Not sure about the reasons but the base image is also ancient...upgrade to bookworm would be recommended
There was a problem hiding this comment.
apt would install the latest jdk, I did not find the way to install the old version through apt...
There was a problem hiding this comment.
have you tried:
apt-cache policy zulu8-ca-jdk
I don't think this might be the right way to go into...I think those tests should be ignored/stabilized instead of blaming the JDK - and adding quirks to the backing system....
what if a test fails for some developer? they should downgrade their jdk as well?
I wonder if those tests are there to provide coverage of JDK compatibility or to ensure that a feature works - is the feature impaired? if not shouldn't the tests be adjusted so that they don't detect jdk versions as failures?
There was a problem hiding this comment.
The following packages have unmet dependencies:
zulu8-jdk : Depends: zulu8-jre (= 8.0.262-3) but 8.0.392-1 is to be installed
Depends: zulu8-jdk-headless (= 8.0.262-3) but 8.0.392-1 is to be installed
Depends: zulu8-doc (= 8.0.262-3) but 8.0.392-1 is to be installed
Depends: zulu8-ca-jdk (= 8.0.262-3) but 8.0.392-1 is to be installed
E: Unable to correct problems, you have held broken packages.apt-cache policy zulu8-jdk could display some history versions, but install also failed. :(
|
I thinked I submitted my notes...whatever |
|
Ahh sorry @kgyrtkirk the page didn't refresh. I can revert if you want. |
|
no worries - it was my bad; github only shows |
No description provided.