Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdk17 #15

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add jdk17 #15

merged 2 commits into from
Jan 16, 2024

Conversation

wecharyu
Copy link
Contributor

Add jdk17 to support hive sonar analysis apache/hive#5004

@wecharyu
Copy link
Contributor Author

cc: @kgyrtkirk @zabetak

@zabetak
Copy link
Collaborator

zabetak commented Jan 15, 2024

Thanks for the PR @wecharyu . How did you test these changes?

@kgyrtkirk
Copy link
Owner

I guess sw java 17 should configure like the others

@wecharyu
Copy link
Contributor Author

I'm testing locally, zulu-17 package seems not be found, let me check it.

@wecharyu
Copy link
Contributor Author

@zabetak @kgyrtkirk pls take a look again, it could install all jdk locally even though my build failed finally by:

wget: unable to resolve host address 'github.infra.cloudera.com'
Error: building at STEP "RUN /tools/install_toolbox": while running runtime: exit status 4

@zabetak
Copy link
Collaborator

zabetak commented Jan 15, 2024

@wecharyu we may have to revert f63e113. Any thoughts @abstractdog ?

@abstractdog
Copy link
Collaborator

@wecharyu we may have to revert f63e113. Any thoughts @abstractdog ?

yes, absolutely, we forked hive-dev-box in the meantime to cloudera.infra, so upstream should not contain any cloudera specific

@wecharyu
Copy link
Contributor Author

The build success after revert f63e113, and jdk install is successful:

jenkins@d4fd2e76cd83:~$ java -version
openjdk version "1.8.0_392"
OpenJDK Runtime Environment (Zulu 8.74.0.17-CA-linux64) (build 1.8.0_392-b08)
OpenJDK 64-Bit Server VM (Zulu 8.74.0.17-CA-linux64) (build 25.392-b08, mixed mode)
jenkins@d4fd2e76cd83:~$ sw java 17 && . /etc/profile.d/java.sh
sudo: unable to send audit message: Operation not permitted
sudo: unable to send audit message: Operation not permitted
export JAVA_HOME=/usr/lib/jvm/zulu17-ca-amd64/
open a new shell or run: . /etc/profile.d/java.sh
jenkins@d4fd2e76cd83:~$ java -version
openjdk version "17.0.9" 2023-10-17 LTS
OpenJDK Runtime Environment Zulu17.46+19-CA (build 17.0.9+8-LTS)
OpenJDK 64-Bit Server VM Zulu17.46+19-CA (build 17.0.9+8-LTS, mixed mode, sharing)

@kgyrtkirk
Copy link
Owner

ugh...I've reverted that - as that makes it unusable for everyone else outside cldr
I'm using a different branch ... so haven't seen the problem

I've added a github action to check that the image can be built

@wecharyu
Copy link
Contributor Author

@kgyrtkirk Rebased to master, could you take a look again?

@kgyrtkirk kgyrtkirk merged commit c67d8af into kgyrtkirk:master Jan 16, 2024
1 check passed
@kgyrtkirk
Copy link
Owner

thank you @wecharyu ! :)

@wecharyu
Copy link
Contributor Author

@kgyrtkirk BTW, do we need to push the latest image to make sure that hive CI could use it?

@kgyrtkirk
Copy link
Owner

it was always my plan to add a job to hive-ci to have some place to build&update those images...but never had time for it; it should work like ./buildAll push

actually I think this 3rd approach would be to best to start with - as the 1st and 2nd could possibly cause trouble for other people using the CI

@wecharyu
Copy link
Contributor Author

it was always my plan to add a job to hive-ci to have some place to build&update those images

Look forward to this feature. 👍

...or you can push the image to your own dockerhub accoung and specify that image to be used in your PR starting to support jdk17

Let me try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants