Skip to content

Commit

Permalink
Change url.port datatype to long (elastic#339)
Browse files Browse the repository at this point in the history
  • Loading branch information
webmat authored Mar 5, 2019
1 parent 8b9fe9f commit 3dc2338
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 11 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ All notable changes to this project will be documented in this file based on the
of being a nesting of the field set. This goes against a driving principle of ECS,
and has been corrected. #308
* Replaced incorrect examples in `cloud.provider`. #330
* Changed the `url.port` type to `long`. #339

### Added

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ URL fields provide support for complete or partial URLs, and supports the breaki
| <a name="url.full"></a>url.full | If full URLs are important to your use case, they should be stored in `url.full`, whether this field is reconstructed or present in the event source. | extended | keyword | `https://www.elastic.co:443/search?q=elasticsearch#top` |
| <a name="url.scheme"></a>url.scheme | Scheme of the request, such as "https".<br/>Note: The `:` is not part of the scheme. | extended | keyword | `https` |
| <a name="url.domain"></a>url.domain | Domain of the url, such as "www.elastic.co".<br/>In some cases a URL may refer to an IP and/or port directly, without a domain name. In this case, the IP address would go to the `domain` field. | extended | keyword | `www.elastic.co` |
| <a name="url.port"></a>url.port | Port of the request, such as 443. | extended | integer | `443` |
| <a name="url.port"></a>url.port | Port of the request, such as 443. | extended | long | `443` |
| <a name="url.path"></a>url.path | Path of the request, such as "/search". | extended | keyword | |
| <a name="url.query"></a>url.query | The query field describes the query string of the request, such as "q=elasticsearch".<br/>The `?` is excluded from the query string. If a URL contains no `?`, there is no query field. If there is a `?` but no query, the query field exists with an empty string. The `exists` query can be used to differentiate between the two cases. | extended | keyword | |
| <a name="url.fragment"></a>url.fragment | Portion of the url after the `#`, such as "top".<br/>The `#` is not part of the fragment. | extended | keyword | |
Expand Down
2 changes: 1 addition & 1 deletion code/go/ecs/url.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1699,7 +1699,7 @@

- name: port
level: extended
type: integer
type: long
description: >
Port of the request, such as 443.
example: 443
Expand Down
2 changes: 1 addition & 1 deletion generated/csv/fields.csv
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ url.full,keyword,extended,https://www.elastic.co:443/search?q=elasticsearch#top,
url.original,keyword,extended,https://www.elastic.co:443/search?q=elasticsearch#top or /search?q=elasticsearch,1.1.0-dev
url.password,keyword,extended,,1.1.0-dev
url.path,keyword,extended,,1.1.0-dev
url.port,integer,extended,443,1.1.0-dev
url.port,long,extended,443,1.1.0-dev
url.query,keyword,extended,,1.1.0-dev
url.scheme,keyword,extended,https,1.1.0-dev
url.username,keyword,extended,,1.1.0-dev
Expand Down
2 changes: 1 addition & 1 deletion generated/ecs/fields_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,7 @@ url.port:
level: extended
name: port
short: Port of the request, such as 443.
type: integer
type: long
url.query:
description: 'The query field describes the query string of the request, such as
"q=elasticsearch".
Expand Down
2 changes: 1 addition & 1 deletion generated/ecs/fields_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1980,7 +1980,7 @@ url:
level: extended
name: port
short: Port of the request, such as 443.
type: integer
type: long
query:
description: 'The query field describes the query string of the request, such
as "q=elasticsearch".
Expand Down
2 changes: 1 addition & 1 deletion generated/elasticsearch/6/template.json
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,7 @@
"type": "keyword"
},
"port": {
"type": "integer"
"type": "long"
},
"query": {
"ignore_above": 1024,
Expand Down
2 changes: 1 addition & 1 deletion generated/elasticsearch/7/template.json
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,7 @@
"type": "keyword"
},
"port": {
"type": "integer"
"type": "long"
},
"query": {
"ignore_above": 1024,
Expand Down
2 changes: 1 addition & 1 deletion generated/legacy/schema.csv
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ url.full,keyword,extended,https://www.elastic.co:443/search?q=elasticsearch#top
url.original,keyword,extended,https://www.elastic.co:443/search?q=elasticsearch#top or /search?q=elasticsearch
url.password,keyword,extended,
url.path,keyword,extended,
url.port,integer,extended,443
url.port,long,extended,443
url.query,keyword,extended,
url.scheme,keyword,extended,https
url.username,keyword,extended,
Expand Down
2 changes: 1 addition & 1 deletion schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1856,7 +1856,7 @@
"level": "extended",
"name": "url.port",
"required": false,
"type": "integer"
"type": "long"
},
"url.query": {
"description": "The query field describes the query string of the request, such as \"q=elasticsearch\".\nThe `?` is excluded from the query string. If a URL contains no `?`, there is no query field. If there is a `?` but no query, the query field exists with an empty string. The `exists` query can be used to differentiate between the two cases.",
Expand Down
2 changes: 1 addition & 1 deletion schemas/url.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

- name: port
level: extended
type: integer
type: long
description: >
Port of the request, such as 443.
example: 443
Expand Down

0 comments on commit 3dc2338

Please sign in to comment.