Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the file field crash issue on node 13 #2780

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Apr 19, 2020

People keep running into #2101. The resolutions fix works when put in the top-level package.json (#2601), but I couldn't get it working in the app-graphql package file. Might as well at least document this until apollo-server either bumps their deps or v3 comes out.

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2020

💥 No Changeset

Latest commit: 2a37bf4

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MadeByMike
Copy link
Contributor

I'd support this. Should we link to the Github issues as well? cc/ @timleslie

@Vultraz
Copy link
Contributor Author

Vultraz commented Apr 19, 2020

Done.

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timleslie timleslie merged commit 7a5d7ec into keystonejs:master Apr 20, 2020
@Vultraz Vultraz deleted the mention-file-crash branch April 20, 2020 09:02
Wkasel pushed a commit to gosignal/keystone that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants