-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudinary field doesn't work on Node 13.3.2 #2101
Comments
What version of |
"@keystonejs/file-adapters": "^5.1.0", |
Hm... I fixed the same warning in #1817 and I can't find where this instance may be coming from... |
@Vultraz still broken on node 13.3.2. I think this is related to this: |
Ah, pretty sure we hit this a few weeks ago too, right @MadeByMike? If my notes are to be believed it was a the combination of an outdated It manifested as a throw/catch loop, leading to a stack overflow. The loop traversed the following calls:
At the time, we fixed our deploy by switching to Node v12.4.1. I can't remember if there was a more general fix and my notes don't speak to it. @MadeByMike, do you recall what the outcome was? We probably bumped some packages or something.. |
Yes! This is totally that issue. It's an upstream problem and we changed our node version to fix it. Is there something more we can do to help users who might encounter this? |
@molomby @MadeByMike I believe that updated versions of the affected dependencies have all been released so we're not blocked, and now either: a) we need to ensure those (and related) deps are updated and we release a new version of the affected packages; or Any chance someone can pick this up and confirm we've updated what we needed to, things have been released, and we can close this out? |
Still an issue on node v13.9.0 with these deps:
|
Fixes keystonejs#2101. Currently, apollo-server-express depends on apollo-server-core which depends on graphql-upload ^8.0.2. graphql-upload 9.0.0 updated its own fs-capacitor dependency to a newer version that supports Node 13, but apollo-server-core hasn't updated its own graphql-upload dependency yet. Solve this by just forcing a compatible version of graphql-upload (currently the latest 10.0.0) to be used.
Can confirm this is still an issue:
Node:
package.json
|
Reading more about this issue upstream I noticed this is working for some people: jaydenseric/graphql-upload#170 (comment) |
going back to node v12.6 fixed it for me |
Here is a comment of apollo-server dev: Apollo will not be bumping As Now, I tried looking in my project using Keystone where the broken
(this is after applying a resolution as described above. without it versions of So I'll try to look into it into more detail, in the meantime I'd be glad to have someone from the dev team review this and verify if this would be a viable solution. |
This is still an issue for me. Not sure what happened but it was working on node 14.4, but then I upgraded to node v14.13.0, and it broke again. Reverting back to v14.4 didn't fix it. Reverting to v12.4 did. I also tried this in my package.json, but that doesn't seem to have done anything:
|
Fixed it! I was using npm, not yarn, which doesn't have resolutions. So the fix is to use the above resolution with your package.json, but add this script:
|
This is kind of a pain because if someone deletes their I know this is way upstream, but is there anything we can do to fix it in keystone? |
Fixed in |
Bug report
Not sure if this is upstream or not..
Trying to use the cloudinary field on Node 13.3.2. It gives the error
(node:50514) [DEP0135] DeprecationWarning: ReadStream.prototype.open() is deprecated
in the console and a 'nested error' in the Admin UI.Reverting back to node 12.13 fixes it for now
System information
The text was updated successfully, but these errors were encountered: