test(developer): kmcmplib compiler unit tests 5 #12612
Open
+158
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection cannot be reached
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
developer/compilers/
test
…compiler-unit-tests-5
…cpp and kmn_compiler_errors.h
…wsRequired inside it
…ection from gtest-compiler-test.cpp
|
Ready to review P;ease note that the code for |
mcdurdin
approved these changes
Nov 26, 2024
|
|
||
| sFlag = 0; | ||
| sFlag = 0; |
There was a problem hiding this comment.
Suggested change
| sFlag = 0; |
nit only 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Test based unit tests for Compiler.cpp
As it was identified that no recursive call was made to
GetXStringImpl()from within the virtual key case (case 11), the checks (Compiler.cpp) and resulting error messages (kmn_compiler_errors.h) when other keywords were identified within a virtual key section were stripped out. The error messages removed were:ERROR_StringInVirtualKeySectionERROR_AnyInVirtualKeySectionERROR_BeepInVirtualKeySectionERROR_IndexInVirtualKeySectionERROR_OutsInVirtualKeySectionERROR_ContextInVirtualKeySectionERROR_CallInVirtualKeySectionERROR_InvalidInVirtualKeySectionIn addition, three variables relating to the parsing of virtual keys were localised by turning the case into a block.
The corresponding errors were also removed from
kmn_compiler_messages.ts.TODO comments in
gtest-compiler-test.cppwere also removed.A separate issue and fix were not written, but the compiler changes incorporated here.
Continues PR #12489
@keymanapp-test-bot skip