Add support for npm engine #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezekg
commented
Nov 1, 2024
| require 'minitar' | ||
| require 'zlib' | ||
|
|
||
| class ProcessDockerImageWorker < BaseWorker |
There was a problem hiding this comment.
Spoilers! 😉 Rip this out into a separate PR.
ezekg
force-pushed
the
feature/npm-engine
branch
from
b63678f to
7b4c4b0
Compare
ezekg
commented
Nov 1, 2024
ezekg
force-pushed
the
feature/npm-engine
branch
2 times, most recently
from
c926e83 to
5568721
Compare
ezekg
commented
Nov 1, 2024
ezekg
commented
Nov 1, 2024
ezekg
force-pushed
the
feature/npm-engine
branch
2 times, most recently
from
127b774 to
f038570
Compare
ezekg
commented
Nov 2, 2024
ezekg
force-pushed
the
feature/npm-engine
branch
3 times, most recently
from
cc14193 to
eee1e73
Compare
ezekg
commented
Nov 5, 2024
app/controllers/api/v1/release_engines/npm/package_metadata_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/api/v1/release_engines/npm/package_metadata_controller.rb
Show resolved
Hide resolved
ezekg
commented
Nov 5, 2024
| artifact.update!(status: 'UPLOADED') | ||
|
|
||
| BroadcastEventService.call( | ||
| event: 'artifact.upload.succeeded', |
There was a problem hiding this comment.
Note: update Zapier with new event.
ezekg
force-pushed
the
feature/npm-engine
branch
from
b0895e0 to
4c5b39f
Compare
ezekg
commented
Nov 5, 2024
| # FIXME(ezekg) https://github.com/brianhempel/active_record_union/issues/35 | ||
| last_modified = artifacts.maximum(:"#{artifacts.table_name}.updated_at") | ||
| return unless | ||
| stale?(artifacts, last_modified:, cache_control: { max_age: 1.day, private: true }) |
There was a problem hiding this comment.
Rip out the PyPI etag stuff into a separate PR.
ezekg
commented
Nov 5, 2024
app/controllers/api/v1/release_engines/npm/package_metadata_controller.rb
Outdated
Show resolved
Hide resolved
ezekg
force-pushed
the
feature/npm-engine
branch
7 times, most recently
from
fc7035f to
44098d5
Compare
ezekg
force-pushed
the
feature/npm-engine
branch
2 times, most recently
from
9566850 to
44fbd9e
Compare
ezekg
force-pushed
the
feature/npm-engine
branch
from
44fbd9e to
2c19e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #489. In the end, it should be as simple as
npm packandkeygen upload example-1.0.0.tgz— the rest should be automatically done by the engine. Like with PyPI and Rubygems,npm pushwill not be supported right away.Prereqs
Add SHA1 checksum flag to CLI: Add support for SHA1 checksum algorithm keygen-cli#23Subreqs
npm.pkg.keygen.shsubdomain.