Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #798. This gem has been causing outages lately as we scale. Right now, I'm still seeing slow Lua scripts when deleting items from large sets, e.g. when a spike of requests come in and jobs are queued up for each request, or when a lot of scheduled jobs are pushed to the queue. I tried to fix this upstream, but there's more issues and I don't have time to debug.
Follow up to fc1b739 (i.e. the fix for the big outage), which removed all mission-critical use of the gem. If and when we need job uniqueness, we can reach for Sidekiq Ent, which has timing guarantees.