add fixme

keygen-sh · Nov 5, 2024 · 7aff5e6 · 7aff5e6
1 parent 4c5b39f
commit 7aff5e6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/controllers/api/v1/release_engines/npm/package_metadata_controller.rb b/app/controllers/api/v1/release_engines/npm/package_metadata_controller.rb
@@ -19,6 +19,7 @@ def show
       authorize! artifacts,
         to: :index?
 
+      # FIXME(ezekg) https://github.com/brianhempel/active_record_union/issues/35
       last_modified = artifacts.maximum(:"#{artifacts.table_name}.updated_at")
       latest        = artifacts.first
       metadata      = artifacts.reduce(

diff --git a/app/controllers/api/v1/release_engines/pypi/simple_controller.rb b/app/controllers/api/v1/release_engines/pypi/simple_controller.rb
@@ -32,7 +32,7 @@ def show
       authorize! artifacts,
         to: :index?
 
-      # FIXME(ezekg) why doesn't rails qualify the column name? unions cause an ambiguous column error
+      # FIXME(ezekg) https://github.com/brianhempel/active_record_union/issues/35
       last_modified = artifacts.maximum(:"#{artifacts.table_name}.updated_at")
       return unless
         stale?(artifacts, last_modified:, cache_control: { max_age: 1.day, private: true })