Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak-X Logging Design Document #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasdarimont
Copy link

No description provided.

Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasdarimont Thanks for opening this one. That is an important area in the context of troubleshooting.

In general, the proposal herein makes a lot of sense including the possibility to use different formats, starting with JSON.

I would like to propose some changes to the document so that we start linking things together.

I just sent a PR to the configuration design document with some updates to throubleshoting. Please take a look at #240.

My proposal is that we include in your proposal:

  • Additional properties for logging and their purpose
  • Additional CLI commands for logging (if necessary)
  • Impact on the server distribution
  • Examples of how users should configure logging using the CLI

And perhaps answering these questions when doing above:

  • How to define a logging level?
  • How to format log entries?
  • How to change the log format?
  • Shall we provide a log directory in the distribution?
  • What is the default provider and settings for dev and production profiles?

By doing this, we should be able to agree on the top-level requirements, usage, and usability.

I also agree with you that we should start small, with a focus on what Quarkus provides, and then discuss integration with other providers/services

Please, let me know what do you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants