[MUONDigi] Adding a digitizer of IDEA Muon system. #24
Conversation
Add missing GaudiAlgLib
|
|
||
| datatypes: | ||
|
|
||
| extension::MCRecoMuonSystemDigiAssociation: |
There was a problem hiding this comment.
Why not using MCRecoTrackerAssociation https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L634 ?
There was a problem hiding this comment.
Can it be used for linking between digi and sim? I fount it relates between reco and sim..
On another hand I'd like to see if there is an association also to store the validation data (e.g: simDigipPositionDifference)
| // Detector efficiency | ||
| FloatProperty m_efficiency{this, "efficiency", 0.95, "Detector efficiency"}; | ||
|
|
||
| // Declaration of validation distribution |
There was a problem hiding this comment.
Can you add a flag, set to false by default, to produce these collections? See e.g. https://github.com/key4hep/k4RecTracker/blob/master/DCHdigi/include/DCHsimpleDigitizerExtendedEdm.h#L78 (the branch will unfortunately still be there I am afraid)
| DataHandle<podio::UserDataCollection<double>> m_simDigiDifferenceZ{"simDigiDifferenceZ", Gaudi::DataHandle::Writer, this}; // mm | ||
|
|
||
| // Random Number Service | ||
| IRndmGenSvc* m_randSvc; |
There was a problem hiding this comment.
@jmcarcell let us know if a consensus was reached on which random number generator we should use
| // y resolution in mm | ||
| FloatProperty m_y_resolution{this, "yResolution", 1.0, "Spatial resolution in the y direction [mm]"}; | ||
|
|
||
| // z resolution in mm |
There was a problem hiding this comment.
I don't understand why we need 3 numbers here. Since you do the smearing in local coordinates (as it should), 2 numbers should be sufficient no? OR at least we should put ine by default to 0, otherwise we really smear in the 3 dimensions.
BEGINRELEASENOTES
Defining a first draft for the muon system digitizer, which can do the following tasks:
ENDRELEASENOTES