Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrackingCellIDEncodingSvc: add service to set the Cell ID encoding st… #134

Merged
merged 6 commits into from
Sep 13, 2023
Merged

TrackingCellIDEncodingSvc: add service to set the Cell ID encoding st… #134

merged 6 commits into from
Sep 13, 2023

Conversation

andresailer
Copy link
Collaborator

@andresailer andresailer commented Aug 30, 2023 •
edited
Loading

…ring for iLCSoft track reconstruction

BEGINRELEASENOTES

  • TrackingCellIDEncodingSvc: add service to set the Cell ID encoding string for iLCSoft track reconstruction

ENDRELEASENOTES

This is part of #27

Depends on

@andresailer andresailer requested a review from hegner August 31, 2023 11:29
hegner
hegner previously requested changes Sep 6, 2023
View reviewed changes
Copy link

@hegner hegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now the code does not even compile. Can you address that issue?

k4MarlinWrapper/src/components/TrackingCellIDEncodingSvc.cpp Show resolved Hide resolved
test/gaudi_opts/geoTest_cld.py Show resolved Hide resolved
@andresailer
Copy link
Collaborator Author

As of now the code does not even compile. Can you address that issue?

It doesn't compile because it needs the other PRs merged first.

@hegner
Copy link

hegner commented Sep 6, 2023

Sorry, wasn't reading carefully then.

@andresailer andresailer requested a review from hegner September 13, 2023 08:30
@andresailer andresailer linked an issue Sep 13, 2023 that may be closed by this pull request
Try to replace MarlinDD4hep processor with GeoSvc #27
Closed
@andresailer
Copy link
Collaborator Author

All tests that are expected to succeed are now successful.

@andresailer andresailer dismissed hegner’s stale review September 13, 2023 14:45

Addressed all relevant remarks, compilation works now

@andresailer andresailer merged commit 714c96b into key4hep:main Sep 13, 2023
@andresailer andresailer deleted the cellIDSvc branch September 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcarcell jmcarcell jmcarcell left review comments

@hegner hegner Awaiting requested review from hegner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to replace MarlinDD4hep processor with GeoSvc
3 participants
@andresailer @hegner @jmcarcell