Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LCIO to EDM4hep conversion functionality #11

Merged
merged 87 commits into from
Jun 13, 2023
Merged

Add LCIO to EDM4hep conversion functionality #11

merged 87 commits into from
Jun 13, 2023

Commits on Mar 13, 2023

  1. Add LCIO to EDM4hep conversion functionality

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    07ab63c View commit details
    Browse the repository at this point in the history

  2. Minor cleanups

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5a9d333 View commit details
    Browse the repository at this point in the history

  3. Add new header to PUBLIC_HEADER of target

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    402a92b View commit details
    Browse the repository at this point in the history

  4. Make object mapping names easier to read

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    00f78f9 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary temp variables

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3a1b768 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary nullptr check

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    589c047 View commit details
    Browse the repository at this point in the history

  7. Add particleID relation resolution for RecoParticles

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cad698e View commit details
    Browse the repository at this point in the history

  8. Comment unnecessary loop until underlying issue is resolved

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    defd6cf View commit details
    Browse the repository at this point in the history

  9. Convert ParticleIDs as part of the ReconstructedParticles

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4e42c41 View commit details
    Browse the repository at this point in the history

  10. Format commented code block

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d4c0e65 View commit details
    Browse the repository at this point in the history

  11. Add include guards

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    75bed64 View commit details
    Browse the repository at this point in the history

  12. Add library for basic comparisons of LCIO and EDM4hep

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    76e1296 View commit details
    Browse the repository at this point in the history

  13. Cleanup and clarification of simulator status

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4523cb2 View commit details
    Browse the repository at this point in the history

  14. Fix typo in function name 

    Discovered by linker
    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    87155c9 View commit details
    Browse the repository at this point in the history

  15. Add a standalone executable for converting LCIO to EDM4hep

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    232325b View commit details
    Browse the repository at this point in the history

  16. Move comparison library to subfolder

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1763077 View commit details
    Browse the repository at this point in the history

  17. Add executable for comparing lcio and edm4hep file contents

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5813008 View commit details
    Browse the repository at this point in the history

  18. Add nullptr check

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    77f7346 View commit details
    Browse the repository at this point in the history

  19. Change TPCHit -> RawTimeSeries

    @jmcarcell @tmadlener
    jmcarcell authored and tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b5aacff View commit details
    Browse the repository at this point in the history

  20. Adding ParticleID to Collections

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    aa29c4c View commit details
    Browse the repository at this point in the history

  21. Added a Nullptr check before every map lookup to make what we are loo… 

    …king for is actually in the file and not a removed object.
    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8b4bc01 View commit details
    Browse the repository at this point in the history

  22. [clang-format] Format fixes

    @tmadlener
    tmadlener committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4606481 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. made a seperate function to create simCaloHitContributionCollections

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    01ec81b View commit details
    Browse the repository at this point in the history

  2. changed the name of the createCaloHitContributions to be in line with… 

    … other names and removed now redundant code.
    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d529718 View commit details
    Browse the repository at this point in the history

  3. [clang-format] Fix formatting

    @tmadlener
    tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    ec4b331 View commit details
    Browse the repository at this point in the history

  4. some small adjustments to names and docstrings

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    991cd4e View commit details
    Browse the repository at this point in the history

  5. restoring file

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4ffaf81 View commit details
    Browse the repository at this point in the history

  6. some small changes to names and error messages

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    1351d58 View commit details
    Browse the repository at this point in the history

  7. Fixing a typo making the Associations not work

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    8ca79c4 View commit details
    Browse the repository at this point in the history

  8. slight change to the interface of convertSimCalorimeterHit to make it… 

    … more inline with the other methods
    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    76f0d57 View commit details
    Browse the repository at this point in the history

  9. Only add MCParticle if there is one to add 

    Remove unnecessary scope
    @tmadlener
    tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    987af8a View commit details
    Browse the repository at this point in the history

  10. Rename output collection

    @tmadlener
    tmadlener committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bc369f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Add .vscode folder to .gitignore

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    a058fa2 View commit details
    Browse the repository at this point in the history

  2. Change to the tests to handle LCrelations without from type.

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    9cb6427 View commit details
    Browse the repository at this point in the history

  3. Chnage in compare for Vectors to make it nan safe.

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    379afee View commit details
    Browse the repository at this point in the history

  4. ome debug messages

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    76216a9 View commit details
    Browse the repository at this point in the history

  5. removing some debug prints

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    24c2df8 View commit details
    Browse the repository at this point in the history

  6. adding a conversion of the EventHeader and its data

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    f2079ba View commit details
    Browse the repository at this point in the history

  7. changed the tests to also check for same EventHeader information.

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    a9c125f View commit details
    Browse the repository at this point in the history

  8. [clang-format] Fix style

    @tmadlener
    tmadlener committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6132b05 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. change to the reading of patch Files to ignore spaces infront of type… 

    … names
    @FinnJohannsen
    FinnJohannsen committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ea8f727 View commit details
    Browse the repository at this point in the history

  2. removal of some debug output

    @FinnJohannsen
    FinnJohannsen committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    09b8a7c View commit details
    Browse the repository at this point in the history

  3. removing alternative reading function

    @FinnJohannsen
    FinnJohannsen committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    98c1a54 View commit details
    Browse the repository at this point in the history

  4. Avoid unnecessary string copies

    @tmadlener
    tmadlener authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ef708df View commit details
    Browse the repository at this point in the history

  5. Remove debug try-catch block

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    3e46e9b View commit details
    Browse the repository at this point in the history

  6. [clang-format] Fix formatting

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b704658 View commit details
    Browse the repository at this point in the history

  7. Add a warning for missing From/ToType when converting relations

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b7b81ef View commit details
    Browse the repository at this point in the history

  8. change to the reading of patch Files to ignore spaces infront of type… 

    … names
    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1b08060 View commit details
    Browse the repository at this point in the history

  9. removal of some debug output

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1a1a669 View commit details
    Browse the repository at this point in the history

  10. removing alternative reading function

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    97a9456 View commit details
    Browse the repository at this point in the history

  11. Avoid unnecessary string copies

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    8a7bd10 View commit details
    Browse the repository at this point in the history

  12. Remove debug try-catch block

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d30b363 View commit details
    Browse the repository at this point in the history

  13. [clang-format] Fix formatting

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ab8a3d3 View commit details
    Browse the repository at this point in the history

  14. Add a warning for missing From/ToType when converting relations

    @tmadlener
    tmadlener committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    da2d34a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Create README.md

    @FinnJohannsen
    FinnJohannsen authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    8643c12 View commit details
    Browse the repository at this point in the history

  2. Avoid unnecessary string copies

    @tmadlener @FinnJohannsen
    tmadlener authored and FinnJohannsen committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    fa31c89 View commit details
    Browse the repository at this point in the history

  3. [clang-format] Fix formatting

    @tmadlener @FinnJohannsen
    tmadlener authored and FinnJohannsen committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    49be81c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. fixing of some typos

    @FinnJohannsen
    FinnJohannsen committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    e45bf00 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. fixing an error in the reading of files that had trailing whitespaces… 

    … as well as changing a Warning.
    @FinnJohannsen
    FinnJohannsen committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e1f5394 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-lcioconv' into read-fix

    @tmadlener
    tmadlener authored May 3, 2023
    Configuration menu
    Copy the full SHA
    915199e View commit details
    Browse the repository at this point in the history

  3. updating the README

    @FinnJohannsen
    FinnJohannsen committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3a177dd View commit details
    Browse the repository at this point in the history

  4. [clang-format] Fix formatting

    @tmadlener
    tmadlener committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3a68e67 View commit details
    Browse the repository at this point in the history

  5. Update documentation

    @tmadlener
    tmadlener committed May 3, 2023
    Configuration menu
    Copy the full SHA
    daf488f View commit details
    Browse the repository at this point in the history

  6. Add documentation and fix LCRelation conversions

    @tmadlener
    tmadlener authored May 3, 2023
    Configuration menu
    Copy the full SHA
    61fe9dd View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into add-lcioconv

    @tmadlener
    tmadlener authored May 3, 2023
    Configuration menu
    Copy the full SHA
    96ff112 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. more documentation

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0c69f86 View commit details
    Browse the repository at this point in the history

  2. added an example to the doc and merged two documentations.

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6fba945 View commit details
    Browse the repository at this point in the history

  3. fixing some typos and changing SubSet into Subset for consistency.

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    65affeb View commit details
    Browse the repository at this point in the history

  4. changing SubSet to Subset for consistency

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f2c03f7 View commit details
    Browse the repository at this point in the history

  5. adjustments to the documentation file

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    614f15f View commit details
    Browse the repository at this point in the history

  6. first attempt of converting LCIntVec collection, compiles and runs af… 

    …ter some weird adjustment. Seg-faults in podio-dump
    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7cf119d View commit details
    Browse the repository at this point in the history

  7. Added a conversion for LCFloatVec and LCIntVec Collections.

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d14632c View commit details
    Browse the repository at this point in the history

  8. conversion of the event parameters

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    ed6bf4e View commit details
    Browse the repository at this point in the history

  9. changed the conversion of LCVec's to a template

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e377bdc View commit details
    Browse the repository at this point in the history

  10. change of convertEventParameters function to be more generall

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4c28fe0 View commit details
    Browse the repository at this point in the history

  11. Update k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepCo… 

    …nv.h
    @tmadlener
    tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0e04d40 View commit details
    Browse the repository at this point in the history

  12. Update doc/LCIO2EDM4hep.md

    @tmadlener
    tmadlener committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0443519 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. [format] Format cleanup, small re-org and README clarifications

    @tmadlener
    tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    19348fb View commit details
    Browse the repository at this point in the history

  2. Minor overhaul of documentation

    @tmadlener
    tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f1bfca3 View commit details
    Browse the repository at this point in the history

  3. [format] Whitespace cleanup

    @tmadlener
    tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    6ae5623 View commit details
    Browse the repository at this point in the history

  4. Rename conversion functions for less ambiguity

    @tmadlener
    tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a6ce31e View commit details
    Browse the repository at this point in the history

  5. Add conversion of MCRecoCaloParticleAssociations

    @tmadlener
    tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    bb79f53 View commit details
    Browse the repository at this point in the history

  6. Conversion of information in LCRunHeader

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    366411d View commit details
    Browse the repository at this point in the history

  7. Conversion of ParticleIDs of the Cluster Collection

    @FinnJohannsen @tmadlener
    FinnJohannsen authored and tmadlener committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    44e8ae0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'master' into add-lcioconv

    @tmadlener
    tmadlener committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    326be85 View commit details
    Browse the repository at this point in the history

  2. Fix capitalization of subdetectorHitNumbers

    @tmadlener
    tmadlener committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    189cddb View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Adapt to podio change to string_views

    @tmadlener
    tmadlener committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    93012b4 View commit details
    Browse the repository at this point in the history