Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GeoSvc to get dd4hep geometry instead of loading it ourselves #17

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

Zehvogel
Copy link
Collaborator

@Zehvogel Zehvogel commented Nov 28, 2023

BEGINRELEASENOTES

  • Use GeoSvc to get dd4hep geometry instead of loading it ourselves
  • Test if exported geometry contains anything

ENDRELEASENOTES

resolves #16

@Zehvogel
Copy link
Collaborator Author

looks like the acts dd4hep plugin tries to also convert the calorimeters and fails doing that. After that there are no tracking surfaces...
Commenting out the calorimeter in the ODD fixes this locally but there must be another way as this does not show up in the usage of the ODD by acts elsewhere? @paulgessinger?

[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep geometry into Acts geometry
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: BeamPipe
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: Pixels
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: PST
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: ShortStrips
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: LongStrips
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: Solenoid
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: ECal
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: HCal
[ctest] 1: 13:18:27    D2A_V:ECal     ERROR     Misconfiguration in volume building detected

@paulgessinger
Copy link
Collaborator

paulgessinger commented Nov 28, 2023

In the other ODD workflows, ACTS ignores the calorimeters once it determines that there are no sensitive surfaces that it can pick up. I added that in acts-project/acts#2514

@Zehvogel
Copy link
Collaborator Author

Thx! It looks like we are still on acts 28.2.0 I will lobby to get a newer version...

@Zehvogel Zehvogel enabled auto-merge (rebase) December 1, 2023 14:26
@Zehvogel Zehvogel merged commit 500a5aa into key4hep:main Dec 1, 2023
4 checks passed
@Zehvogel Zehvogel deleted the geosvc branch December 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActsGeoSvc use GeoSvc to get DD4hep geometry
2 participants