Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Switch to templated links and remove explicit declarations from yaml file #373

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Sep 19, 2024

BEGINRELEASENOTES

  • Switch to templated podio::Links for the Link datatypes
  • Bump the schema version to 3
  • Remove the legacy Association headers that were put in place for a smooth transition to Links

ENDRELEASENOTES

This PR introduces all the existing Link datatypes as typedefs (keeping the same header file names for the collections as before) of podio::LinkCollection<ToT, FromT> and removes their declarations from the yaml file. It also includes the necessary schema evolution code for podio to be able to read back data files that have been written with previous versions of EDM4hep (or at least they will once suitable files have been uploaded for testing).

  • The typedef headers is in include/edm4hep
  • The schema evolution code is in edm4hep/schema_evolution

Both of these can obviously be changed to something more appropriate if necessary.

@tmadlener tmadlener force-pushed the proper-links branch 2 times, most recently from 8fa95c1 to f5827f0 Compare September 26, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant