Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EDep to eDep in SimTrackerHit #274

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Rename EDep to eDep in SimTrackerHit #274

merged 1 commit into from
Feb 22, 2024

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Rename EDep to eDep in SimTrackerHit for consistency with other uses of "eDep"

ENDRELEASENOTES

Fixes #180
I think EDep to eDep fits better the variable usage that we have instead of eDep to EDep

tmadlener
tmadlener reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require schema evolution, but for the generated code this is transparent as in both cases we get getEDep / setEDep, since the first letter of the member variable is capitalized.

@tmadlener tmadlener enabled auto-merge (squash) February 22, 2024 09:28
@tmadlener tmadlener merged commit e445072 into main Feb 22, 2024
18 of 19 checks passed
@tmadlener tmadlener deleted the edep branch February 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent naming of energy deposit in different types
2 participants
@jmcarcell @tmadlener