Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: wiring the vector manager up in synchronize #376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

friendlymatthew
Copy link
Collaborator

This is still a work in progress. This PR adds the wiring logic for FieldTypeVector.

What's been done

Base case:
The JSONLHandler will create a VectorPageManager upon first entry. Need to serialize the entry node.

Rest:
Given the correct BTree and BPTree pages, the VectorPageManager updates the hnsw, then writes information about the freshly inserted vector.

Todo

  1. Currently a linked meta page is unique if it has a different FieldName and FieldType. However with a new storage data structure BTree, we also need to factor in TreeType as well.

  2. FindOrCreateIndex() needs to return a list of unique pages. In the vector case, it should return two pages, the Id to Point mapping BTree and the Friends mapping BPTree.

hnsw.Hnsw will be stateful and it'll only be correct when handleJsonObject gets called last.

Additional thoughts:

  • serialize the entry node case properly

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant