Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "\/" handling #1

Closed
wants to merge 2 commits into from
Closed

Fix "\/" handling #1

wants to merge 2 commits into from

Conversation

2shortplanks
Copy link

No description provided.

@2shortplanks
Fix backslash-forwardslash
132adbf 
According to rfc7159 you can write "\/" to mean literal forward slash

jsonlint doesn't currently seem to know about this.  So it turns "\/" into
"\\/" which is totally wrong (that means literal-backslash literal
forward slash.)

This change changes "\/" into plain old "/".
@2shortplanks
test for backslash forwardslash
830fc83
@oschwald
Copy link

There is also zaach#54, which seems to handle a few more cases.

@2shortplanks
Copy link
Author

Yeah, that seems way more comprehensive.

I leave this up to @kevcenteno which way he wants to go.

  1. Take this minor fix to fix just this issue that I'm seeing
  2. Take Fix string escapes. (issue #37) zaach/jsonlint#54
  3. See if there's another fork of jsonlint that the changes in this fork should be rebased off of
  4. None of the above and just take the dog for a walk

@kevcenteno
Copy link
Owner

I just washed the dog and created a separate PR that takes zaach#54

@kevcenteno kevcenteno closed this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2shortplanks @oschwald @kevcenteno