Don't merge - Steven for review #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: db/schema.rb
Ready User Controller
new file: app/controllers/questions_controller.rb new file: app/views/questions/new.html.erb modified: config/routes.rb
modified: app/controllers/questions_controller.rb modified: app/views/questions/new.html.erb
Question new
added index method to user controller
new file: app/views/questions/show.html.erb
modified: app/controllers/questions_controller.rb
…the user of each modified: app/views/questions/show.html.erb
Sam login
modified: config/routes.rb
modified: app/controllers/answers_controller.rb modified: app/controllers/comments_controller.rb modified: app/views/comments/new.html.erb
Malcolm sunday edits
Final edits
Nifty Search Bar for User Index
Conflicts: app/controllers/comments_controller.rb app/views/comments/new.html.erb app/views/questions/show.html.erb
Conflicts: app/views/comments/new.html.erb app/views/questions/show.html.erb
| console.log(serverResponse) | ||
| $('#comments').append(serverResponse); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Think this is not used? In any case, in general, it's better ux to show / hide / dynamically create forms with JS rather than get+partial (it's a good idea to avoid a network round-trip if we can.)
|
Me likey. This is done well. We can talk in person later about some of the points raised here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.