Fixed #88 and #86

ketanchoyal · Jan 31, 2024 · 5cd7c3f · 5cd7c3f
1 parent 8c55aa0
commit 5cd7c3f
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# [4.2.2] - 31 Jan 2024
+- Fixed `externalIds` in `SuggestionResponse` and `RetrieveResonse` class and generated *.g.dart files again to include these changes.
+- Fixed bug where `proximity` would always resolve to `NoProximity()` even when supplied with a value.
+
 # [4.2.1] - 18 Jan 2024
 - Fixed `externalIds` in `SuggestionResponse` class. Mapbox has changed the response for `externalIds` and it can be nullable now.
 

diff --git a/lib/models/retrieve_response.dart b/lib/models/retrieve_response.dart
@@ -65,7 +65,7 @@ class RetrieveProperties {
     required this.bbox,
     required this.language,
     required this.maki,
-    required this.externalIds,
+    this.externalIds,
     required this.metadata,
   });
 
@@ -82,7 +82,7 @@ class RetrieveProperties {
   final BBox bbox;
   final String language;
   final String maki;
-  final ExternalIds externalIds;
+  final ExternalIds? externalIds;
   final ExternalIds metadata;
 
   factory RetrieveProperties.fromJson(Map<String, dynamic> json) =>

diff --git a/lib/models/retrieve_response.g.dart b/lib/models/retrieve_response.g.dart
diff --git a/lib/models/suggestion_response.g.dart b/lib/models/suggestion_response.g.dart
diff --git a/lib/src/geocoding_api.dart b/lib/src/geocoding_api.dart
@@ -88,7 +88,7 @@ class GeoCoding {
     Location? location,
     Proximity proximity = const NoProximity(),
   }) async {
-    if (proximity is! Location) {
+    if (proximity is! LocationProximity) {
       proximity =
           location != null ? Proximity.Location(location) : const NoProximity();
     }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: mapbox_search
 description: A Flutter package for place search using MapBox Api and for Static map image
-version: 4.2.1
+version: 4.2.2
 
 homepage: https://github.com/ketanchoyal/mapbox_search