confd: Enable config for lldp tx interval #882
Conversation
axkar
force-pushed
the
lldp-tx-interval
branch
from
5996edf to
16c70ba
Compare
axkar
force-pushed
the
lldp-tx-interval
branch
from
16c70ba to
7de414b
Compare
This change introduces the configuration of the tx-interval parameter for the LLDP service, allowing control over the frequency of LLDP hello messages. By reducing the tx-interval, the waiting time for LLDP packets during tests is significantly shortened. This improvement eliminates the need to toggle the interface down and up to force the emission of LLDP packets in the test environment.
axkar
force-pushed
the
lldp-tx-interval
branch
from
7de414b to
57c8031
Compare
| if (systemf("initctl -nbq restart lldpd")) { | ||
| ERROR("Failed to restart lldpd"); | ||
| } |
There was a problem hiding this comment.
Please do not use restart here, we want to "roll in" the next generation at the same time via finit's initctl reload mechanism. The reason for this is simply that changes we add to the /etc/lldpd.d/*.conf may include references to interfaces that have not been created yet. So, instead of restart, use initctl -nbq touch ... construct, used for other services in this file, to mark it for restarting by Finit.
Now, previously we thought lldpd reconfigured itself automatically on SIGHUP, but that does not seem to be the case. To ensure Finit does not send SIGHUP, but instead performs the actual process restart (stop + start) for us, we need to change the .conf snippet in package/skeleton-init-finit/skeleton/etc/finit.d/available/lldpd.conf.
From
service [2345] env:-/etc/default/lldpd lldpd -d $LLDPD_ARGS -- LLDP daemon (IEEE 802.1ab)
to:
service <!> env:-/etc/default/lldpd \
[2345] lldpd -d $LLDPD_ARGS -- LLDP daemon (IEEE 802.1ab)
The <!> construct tells Finit this service does not support SIGHUP.
To test this, without rebuilding from distclean, you need to perform a make skeleton-init-finit-rebuild.
This change introduces the configuration of the tx-interval parameter for the LLDP service, allowing control over the frequency of LLDP hello messages. By reducing the tx-interval, the waiting time for LLDP packets during tests is significantly shortened. This improvement eliminates the need to toggle the interface down and up to force the emission of LLDP packets.
Checklist
Tick relevant boxes, this PR is-a or has-a: