build: Source build id from the correct repo, fix #872 #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INFIX_OEM_PATH is `""` by default (i.e., not empty in `make`'s eyes). So we called `git` with `-C ""`, which it interpreted as "from the current directory" and thus we sourced the autogenerated build id from _buildroot_ instead of Infix. Therefore, make sure to strip any quotes from the OEM path before determining the top directory.
troglobit
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
INFIX_OEM_PATH is
""by default (i.e., not empty inmake's eyes). So we calledgitwith-C "", which it interpreted as "from the current directory" and thus we sourced the autogenerated build id from buildroot instead of Infix.Therefore, make sure to strip any quotes from the OEM path before determining the top directory.
Checklist
Tick relevant boxes, this PR is-a or has-a: