Change boot order #876
Merged
Change boot order #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
change-boot-order
branch
4 times, most recently
from
f110468 to
be8acae
Compare
mattiaswal
force-pushed
the
change-boot-order
branch
2 times, most recently
from
793f085 to
9596bc1
Compare
troglobit
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Like wkz said, it's the single most important feature of the operating system, so I'd like to tip my hat and say: great work on this! 😮 🎉
I only have a few minor grammar and stylistic comments.
Also, very cool to learn about the YANG feature ordered-by user! 🤓
mattiaswal
force-pushed
the
change-boot-order
branch
2 times, most recently
from
18146a7 to
3b20a29
Compare
mattiaswal
force-pushed
the
change-boot-order
branch
from
3b20a29 to
f5e11bf
Compare
mattiaswal
force-pushed
the
change-boot-order
branch
4 times, most recently
from
2d78c94 to
092c82d
Compare
If a test need to clean up itself disregarding test status, it can add an optional test-cleanup phase. This is useful if the test in some circomstances leave the device in a bad state. This can be used to restore the unit to its ordinary state.
* Use new cleanup in infamy to ensure the boot order gets restored * Use new boot order in operational and use RPC to set boot order to remove all SSH commands.
mattiaswal
force-pushed
the
change-boot-order
branch
from
092c82d to
e00737e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: