Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move operational data about software state from confd => yanger #871

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Move operational data about software state from confd => yanger #871

merged 2 commits into from
Dec 16, 2024

Conversation

mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Dec 13, 2024 •
edited
Loading

Statd is now responsible for operational, move last big part (infix-system-software) to yanger.

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal force-pushed the move-operational-from-confd branch from cc128f0 to 0b5a305 Compare December 13, 2024 12:52
@mattiaswal mattiaswal marked this pull request as draft December 13, 2024 13:24
@troglobit
Copy link
Contributor

Would you mind updating the defconfigs for the r2s and riscv as well?

@mattiaswal mattiaswal force-pushed the move-operational-from-confd branch 3 times, most recently from 6ad4ee1 to a649eff Compare December 13, 2024 15:13
@mattiaswal
Move operational data about software state from confd => yanger
5608e94 
Statd is now responsible for operational, move last big part
(infix-system-software) to yanger.
@mattiaswal
test: upgrade: Add some debug print to see whats happen over time
a4ef38f
@mattiaswal mattiaswal force-pushed the move-operational-from-confd branch from a649eff to a4ef38f Compare December 13, 2024 19:33
@mattiaswal mattiaswal requested review from troglobit and wkz December 13, 2024 19:34
@mattiaswal mattiaswal marked this pull request as ready for review December 13, 2024 19:34
wkz
wkz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I see you've added the JSON blobs to test/case/cli/system-output, but no actual test case. Should we have one?

@mattiaswal
Copy link
Contributor Author

Looks great!

I see you've added the JSON blobs to test/case/cli/system-output, but no actual test case. Should we have one?

It is coming.... Be patient.

@mattiaswal mattiaswal merged commit 02a8c3d into main Dec 16, 2024
6 checks passed
@mattiaswal mattiaswal deleted the move-operational-from-confd branch December 16, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkz wkz wkz approved these changes

@troglobit troglobit Awaiting requested review from troglobit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattiaswal @troglobit @wkz