Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BaseOptimizer to handle a mix of tf.Variable and KerasVariable #20534

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

james77777778
Copy link
Contributor

Fix #20517

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (e5351f3) to head (84585c4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20534   +/-   ##
=======================================
  Coverage   82.11%   82.12%           
=======================================
  Files         515      515           
  Lines       47802    47809    +7     
  Branches     7488     7490    +2     
=======================================
+ Hits        39254    39261    +7     
  Misses       6736     6736           
  Partials     1812     1812           
Flag Coverage Δ
keras 81.97% <100.00%> (+<0.01%) ⬆️
keras-jax 65.06% <40.00%> (+<0.01%) ⬆️
keras-numpy 60.03% <40.00%> (+<0.01%) ⬆️
keras-tensorflow 66.04% <100.00%> (+<0.01%) ⬆️
keras-torch 64.98% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 22, 2024
@fchollet fchollet merged commit 5d36ee1 into keras-team:master Nov 22, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 22, 2024
@james77777778 james77777778 deleted the fix-mixed-tfvariables branch November 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply_gradients AttributeError: 'ResourceVariable' object has no attribute 'overwrite_with_gradient'
4 participants