Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tensorflow SparseTensors: Dot merging layer. #937

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

hertschuh
Copy link
Collaborator

Added tf.SparseTensor support for ops:

  • matmul (sparse support was very partial before this PR)
  • squeeze
  • expand_dims

Added tf.SparseTensor support for merging layer:

  • Dot

Added `tf.SparseTensor` support for ops:
- matmul (sparse support was very partial before this PR)
- squeeze
- expand_dims

Added `tf.SparseTensor` support for merging layer:
- Dot
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 94.91% and project coverage change: +0.01% 🎉

Comparison is base (bf04179) 83.80% compared to head (e33e1cf) 83.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   83.80%   83.82%   +0.01%     
==========================================
  Files         318      318              
  Lines       28780    28831      +51     
  Branches     5506     5518      +12     
==========================================
+ Hits        24120    24168      +48     
- Misses       3145     3146       +1     
- Partials     1515     1517       +2     
Flag Coverage Δ
keras_core 83.71% <94.91%> (+0.01%) ⬆️
keras_core-jax 66.98% <15.25%> (-0.11%) ⬇️
keras_core-numpy 60.50% <15.25%> (-0.09%) ⬇️
keras_core-tensorflow 66.95% <94.91%> (+0.04%) ⬆️
keras_core-torch 69.05% <15.25%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/backend/tensorflow/numpy.py 93.93% <94.23%> (-0.03%) ⬇️
keras_core/ops/numpy.py 94.41% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit d0ae69e into keras-team:main Sep 21, 2023
8 checks passed
@hertschuh hertschuh deleted the sparse_dot branch September 21, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants