Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kill process with SIGTERM #197

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

charankamarapu
Copy link
Member

@charankamarapu charankamarapu commented Sep 25, 2023

Previously go-sdk in killing keploy process using os.Kill but it should be changed to SIGTERM as os.Kill cannot be catched by keploy

this will resolve #878

Signed-off-by: charankamarapu <[email protected]>
@re-Tick
Copy link
Contributor

re-Tick commented Sep 26, 2023

LGTM

@charankamarapu charankamarapu merged commit 5c345c1 into keploy:main Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: mockRecord and mockTest commands are not kill by SIGTERM
2 participants