Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a case where some oid values do not get matched in disco #773

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Nov 5, 2024

For an oid like SNMPv2-MIB::sysObjectID.0 = OID: SNMPv2-SMI::enterprises.119.1.84.16.1 disco wasn't matching correctly. This should parse it as a string.

Causes the disco to add the device but not pull in the correct profile.

@i3149 i3149 requested a review from jryburn November 5, 2024 22:49
Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i3149 i3149 merged commit bc719c5 into main Nov 6, 2024
1 check passed
@i3149 i3149 deleted the fix-snmp-disco branch November 6, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants