Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No buffer mode for parquet files which can not be appended to #771

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Oct 28, 2024

Fixes a bug where parquet files will get corrupted because you can't just append one to another.

Adds a new type of data option which forces sinks to flush the data right away instead of buffering.

@kentik-rbarnes this is the fix you're waiting on.

@i3149 i3149 requested a review from jryburn October 28, 2024 04:40
Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i3149 i3149 merged commit bf80b7a into main Oct 28, 2024
1 check passed
@i3149 i3149 deleted the staging branch October 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants