New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Rails 7.1 or above, use the named bold param #43

Merged

kenn merged 1 commit into kenn:master from DougEdey:de/update_log_params

Nov 4, 2023

DougEdey commented Nov 3, 2023

When upgrading to Rails 7.1 we're getting the following deprecation warning:

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`). (called from debug at .../bundler/gems/standby-6fbc05940118/lib/standby/active_record/log_subscriber.rb:7)

This checks the Rails major/minor combo to use the named bold param for the log colour

DougEdey force-pushed the de/update_log_params branch from 4f22d38 to 7c42916 Compare

November 3, 2023 19:53


          For Rails 7.1 or above, use the named bold param

a8c7787

DougEdey force-pushed the de/update_log_params branch from 7c42916 to a8c7787 Compare

November 3, 2023 20:17

kenn merged commit 3174c25 into kenn:master

0 of 4 checks passed

Owner

kenn commented Nov 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet