Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NTT expand #1273

Open
wants to merge 2 commits into
base: dev/3.0
Choose a base branch
from
Open

Add NTT expand #1273

wants to merge 2 commits into from

Conversation

cqqd3
Copy link

@cqqd3 cqqd3 commented Nov 22, 2024

  • Optimize expand
  • Add ctest
  • Add benchmark test

zhen8838
zhen8838 reviewed Nov 22, 2024
View reviewed changes
ntt/include/nncase/ntt/shape.h
@@ -313,18 +317,6 @@ constexpr size_t linear_offset(const Index &index,
return offset;
}

template <class Strides>
ranked_shape<Strides::rank()> unravel_index(const size_t offset,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function has been used in multiple cores code generators and needs to be preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen8838 zhen8838 zhen8838 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqqd3 @zhen8838