Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added synergy sidebar #2713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexis-Curiel
Copy link

Added Synergy Sidebar to the Main Sidebar
New functionality proposal to add a new Sidebar that displays a simplified version of Wiki / Synergy.

I worked on this feature as this is something that I feel I would really love to have during matches as I'm not familiar with the pokemon types and I constantly have the need to search for pokemon that share types with my current composition

I currently use team builder for this function but during a match having the modal covering most of the screen is quite an issue for me.

NOTE: it seems there's many lines affected by prettier extension

Screenshots

Captura de Pantalla 2025-01-18 a la(s) 13 44 59 Captura de Pantalla 2025-01-18 a la(s) 13 41 15 Captura de Pantalla 2025-01-18 a la(s) 13 51 43

Functionality

  • When No Type selected shows a small message: i.e state: selectedSynergies: [ ]
  • When clicking one type, it adds it to an array and filter the pokemon of that type. i.e state: selectedSynergies: ["FIRE"]
  • If clicking in a different type, it would show pokemon that have both types. i.e state: selectedSynergies: ["FIRE", "FLYING"]
  • If two types are selected and you click a new one, the two previous selections are emptied and shows just the new type. i.e state: selectedSynergies: ["WATER"]
  • if you have one type and you click again in the same one it would be removed from the array. i.e state: selectedSynergies: [ ]

@sylvainpolletvillard
Copy link
Collaborator

Hmm i don't know, we already have 3 ways to get this information: synergy detail tooltip, wiki>synergies, and team planner.

The double-type overlap filter is interesting, but i just worked on something similar last week for wiki>synergies #2700

For me, the main argument is:

having the modal covering most of the screen is quite an issue for me.

But then what about just opening the wiki in a separate window ? You can't presume how much this sidebar will cover from the screen, we have players using very low resolutions

@sylvainpolletvillard
Copy link
Collaborator

sylvainpolletvillard commented Jan 19, 2025

NOTE: it seems there's many lines affected by prettier extension

Yes this MR can't be merged in this state no matter what because of all the lines changed with the formatter. We use Biome as a formatter for this project.

@sylvainpolletvillard
Copy link
Collaborator

Also need to be said, it's the second time we get a PR about a sidebar UI, and the second time i wish this could have been discussed on Discord #idea before getting into work.

@Alexis-Curiel
Copy link
Author

Yes this MR can't be merged in this state no matter what because of all the lines changed with the formatter. We use Biome as a formatter for this project.

That's not really a big deal, I could amend the formatter changes quite easy

Also need to be said, it's the second time we get a PR about a sidebar UI, and the second time i wish this could have been discussed on Discord #idea before getting into work.

Also not really a problem it was a good practice doing this to get familiar with how the code is currently structured but if this is a No then I guess I'll just close the request.

is there any roadmap of pending changes?

@sylvainpolletvillard
Copy link
Collaborator

I dont want to say a straight up no, I just wish the idea could have been discussed further first, to refine the needs, the interface... We use the game Discord server and the #idea section to discuss publicly of new features, to collect some feedback before working on it. That's how we process usually to evolve the game, we don't have a predefined roadmap. I suggest you create a topic for the idea to be discussed further publicly, instead of here on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants