Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce option for sorting deps in the same ordering as npm #304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nokel81
Copy link

@Nokel81 Nokel81 commented Dec 6, 2023

  • The option is --npm-sort-ordering, with the default value of false

resolves #234

- The option is `--npm-sort-ordering`, with the default value of `false`
@Nokel81
Copy link
Author

Nokel81 commented Dec 6, 2023

I know that this is rather hacky, but I could not figure out another way to pass in an argument for the over's

Also, how would I go about adding a unit test for this?

Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I’d like us to avoid the use of flags. We should be able to infer the npm version from the package.json or the users environment variables. Configuration flags mean that different invocations result in different outputs and I want to avoid that as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use same sorting logic for sorting dependencies as npm v7
2 participants