feat: don’t sort scripts when npm-run-all2 is installed (#309)

keithamus · Jan 29, 2024 · 542d8ba · 542d8ba
1 parent 93a1cbc
commit 542d8ba
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -163,7 +163,10 @@ const sortScripts = onObject((scripts, packageJson) => {
     return name
   })
 
-  if (!hasDevDependency('npm-run-all', packageJson)) {
+  if (
+    !hasDevDependency('npm-run-all', packageJson) &&
+    !hasDevDependency('npm-run-all2', packageJson)
+  ) {
     keys.sort()
   }
 

diff --git a/tests/scripts.js b/tests/scripts.js
@@ -68,3 +68,20 @@ for (const field of ['scripts', 'betterScripts']) {
     },
   })
 }
+
+for (const field of ['scripts', 'betterScripts']) {
+  test(`${field} when npm-run-all2 is not a dev dependency`, macro.sortObject, {
+    value: { [field]: fixture },
+    expect: { [field]: expectAllSorted },
+  })
+  test(`${field} when npm-run-all2 is a dev dependency`, macro.sortObject, {
+    value: {
+      [field]: fixture,
+      devDependencies: { 'npm-run-all2': '^1.0.0' },
+    },
+    expect: {
+      [field]: expectPreAndPostSorted,
+      devDependencies: { 'npm-run-all2': '^1.0.0' },
+    },
+  })
+}