fix: title text (#236)

keidarcy · May 23, 2024 · 11f9cd7 · 11f9cd7
1 parent 94e6b82
commit 11f9cd7
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 7 deletions.
diff --git a/.github/workflows/publish-image.yml b/.github/workflows/publish-image.yml
@@ -5,7 +5,6 @@ name: publish docker image
 on:
   push:
     branches: ['master']
-  pull_request:
 
 # Defines two custom environment variables for the workflow. These are used for the Container registry domain, and a name for the Docker image that this workflow builds.
 env:

diff --git a/internal/view/service.go b/internal/view/service.go
@@ -162,7 +162,7 @@ func (v *serviceView) headerPagesParam(s types.Service) (items []headerItem) {
 		{name: "Name", value: utils.ShowString(s.ServiceName)},
 		{name: "Cluster", value: utils.ArnToName(s.ClusterArn)},
 		{name: "Capacity provider strategy", value: cpsString},
-		{name: "RoleArn", value: utils.ArnToName(s.RoleArn)},
+		{name: "Role arn", value: utils.ArnToName(s.RoleArn)},
 		{name: "Task definition", value: utils.ArnToName(s.TaskDefinition)},
 		{name: "Propagate tags", value: string(s.PropagateTags)},
 		{name: "Scheduling strategy", value: string(s.SchedulingStrategy)},

diff --git a/internal/view/task.go b/internal/view/task.go
@@ -157,16 +157,16 @@ func (v *taskView) headerPagesParam(t types.Task) (items []headerItem) {
 		{name: "Launch type", value: string(t.LaunchType)},
 		{name: "Capacity provider", value: utils.ShowString(t.CapacityProviderName)},
 		{name: "Subnet ID", value: subnetID},
-		{name: "Cpu Architecture", value: arch},
+		{name: "Cpu architecture", value: arch},
 		{name: "Private IP", value: privateIP},
 		{name: "Execute command", value: strconv.FormatBool(t.EnableExecuteCommand)},
 		{name: "Started by", value: utils.ShowString(t.StartedBy)},
 		{name: "Started at", value: utils.ShowTime(t.StartedAt)},
 		{name: "Pull started at", value: utils.ShowTime(t.PullStartedAt)},
 		{name: "Pull stopped at", value: utils.ShowTime(t.PullStoppedAt)},
-		{name: "StoppedReason", value: utils.ShowString(t.StoppedReason)},
-		{name: "StoppedAt", value: utils.ShowTime(t.StoppedAt)},
-		{name: "StoppingAt", value: utils.ShowTime(t.StoppingAt)},
+		{name: "Stopped reason", value: utils.ShowString(t.StoppedReason)},
+		{name: "Stopped at", value: utils.ShowTime(t.StoppedAt)},
+		{name: "Stopping at", value: utils.ShowTime(t.StoppingAt)},
 		{name: "Platform family", value: utils.ShowString(t.PlatformFamily)},
 		{name: "Platform version", value: utils.ShowString(t.PlatformVersion)},
 		{name: "Tags count", value: strconv.Itoa(len(t.Tags))},

diff --git a/internal/view/task_definition.go b/internal/view/task_definition.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"log/slog"
 	"strconv"
+	"strings"
 
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
 	"github.com/keidarcy/e1s/internal/color"
@@ -126,6 +127,16 @@ func (v *taskDefinitionView) headerPagesParam(t types.TaskDefinition) (items []h
 		placements = append(placements, string(p.Type))
 	}
 
+	arch := "x86_64"
+	if t.RuntimePlatform != nil {
+		arch = strings.ToLower(string(t.RuntimePlatform.CpuArchitecture))
+	}
+
+	OS := "linux"
+	if t.RuntimePlatform != nil {
+		OS = strings.ToLower(string(t.RuntimePlatform.OperatingSystemFamily))
+	}
+
 	items = []headerItem{
 		{name: "Revision", value: utils.ArnToName(t.TaskDefinitionArn)},
 		{name: "Task role", value: utils.ShowString(t.TaskRoleArn)},
@@ -136,9 +147,11 @@ func (v *taskDefinitionView) headerPagesParam(t types.TaskDefinition) (items []h
 		{name: "Placement constraints", value: utils.ShowArray(placements)},
 		{name: "Status", value: string(t.Status)},
 		{name: "Compatibilities", value: utils.ShowArray(compatibilities)},
-		{name: "Requires Compatibilities", value: utils.ShowArray(requiresCompatibilities)},
+		{name: "Requires compatibilities", value: utils.ShowArray(requiresCompatibilities)},
 		{name: "CPU", value: utils.ShowString(t.Cpu)},
 		{name: "Memory", value: utils.ShowString(t.Memory)},
+		{name: "CPU architecture", value: arch},
+		{name: "OS", value: OS},
 		{name: "Registered At", value: utils.ShowTime(t.RegisteredAt)},
 		{name: "Registered By", value: utils.ShowString(t.RegisteredBy)},
 	}