Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bank resource, updated README, optimized variable names #22

Closed
wants to merge 7 commits into from

Conversation

itswisdomagain
Copy link

No description provided.

@itswisdomagain
Copy link
Author

@subomi Do I have to include my test key in package.json? That's what's causing the test to fail...

@subomi
Copy link
Collaborator

subomi commented Sep 29, 2017

You have to set your secret key as an environment variable named "KEY", for local testing.

The errors from the build is already informative of the kind of error. Once tests pass locally, then you can push again.

@itswisdomagain
Copy link
Author

@subomi Local test passes when I set the environment variable locally. How do I set the environment variable for travis? Will it be wise to include my paystack secret key in the package.json file and push?

@subomi
Copy link
Collaborator

subomi commented Oct 11, 2017

Hey wisdom,

It appears the issue was really as a result of the environment variables. Travis removes sensitive information like this away from the build environment as this would allow people to illegally just create a fork to steal important information like secret keys and so allow only those that have write access to a repository to use stored environment variable.

So in your case, your PR did not have access to the stored environment variable in Travis.

The solution was i created a dev branch, merged your fork's master branch into it and created a PR back into this master.

You can see that in #23

I will be closing this PR now, to follow up on this continue pushing to your master, and i will continue fetching & merging, its just a work around for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants